[
https://issues.apache.org/jira/browse/SUREFIRE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877005#comment-17877005
]
ASF GitHub Bot commented on SUREFIRE-2172:
------------------------------------------
michael-o commented on code in PR #768:
URL: https://github.com/apache/maven-surefire/pull/768#discussion_r1732784333
##########
surefire-api/src/main/java/org/apache/maven/surefire/api/report/LegacyPojoStackTraceWriter.java:
##########
@@ -54,7 +52,7 @@ public String writeTraceToString() {
if (isMultiLineExceptionMessage(t)) {
// SUREFIRE-986
String exc = t.getClass().getName() + ": ";
- if (StringUtils.startsWith(builder, exc)) {
+ if (builder.toString().startsWith(exc)) {
Review Comment:
Correct. That should be it.
> StringUtils: yet more of them
> -----------------------------
>
> Key: SUREFIRE-2172
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2172
> Project: Maven Surefire
> Issue Type: Improvement
> Reporter: Elliotte Rusty Harold
> Priority: Minor
> Labels: up-for-grabs
>
> This project contains not one, not two, but **three** different StringUtils
> classes that duplicate functionality in the JDK and elsewhere. One or two of
> them imght be built by shading other classes. They're even sometimes both
> imported in the same classes such as LegacyPojoStackTraceWriter:
> import org.apache.maven.surefire.api.util.internal.StringUtils;
> import static org.apache.maven.surefire.shared.utils.StringUtils.isNotEmpty;
> Figure out what to do about this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
