[
https://issues.apache.org/jira/browse/MSKINS-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874676#comment-17874676
]
Konrad Windszus edited comment on MSKINS-242 at 8/18/24 3:51 PM:
-----------------------------------------------------------------
We should probably consider what is currently supported via prettify:
[https://github.com/googlearchive/code-prettify?tab=readme-ov-file#for-which-languages-does-it-work|https://github.com/googlearchive/code-prettify?tab=readme-ov-file#for-which-languages-does-it-work,]
although I would disregard all non-web, non-java, non-script languages. That
basically boils down to
# java
# xml
# json
# bash
# javascript
We can easily extend support later on if necessary (removing is more difficult).
As style I would just ship `default.min.css`
([https://highlightjs.org/demo#lang=&v=1&theme=default-min]).
was (Author: kwin):
We should probably consider what is currently supported via prettify:
[https://github.com/googlearchive/code-prettify?tab=readme-ov-file#for-which-languages-does-it-work,]
although I would disregard all non-web, non-java, non-script languages. That
basically boils down to
# java
# xml
# json
# bash
# javascript
We can easily extend support later on if necessary (removing is more difficult).
As style I would just ship `default.min.css`
(https://highlightjs.org/demo#lang=&v=1&theme=default-min).
> Replace deprecated prettify JS library
> --------------------------------------
>
> Key: MSKINS-242
> URL: https://issues.apache.org/jira/browse/MSKINS-242
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: fluido-2.0.0
>
>
> The JS library used for code highlighting in
> https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/js/prettify.js
> seems to be based on the legacy library
> https://github.com/googlearchive/code-prettify (unclear which version). As
> that is no longer maintained since quite a while we should switch.
> One alternative is [hightlight.js|https://highlightjs.org/](compare also with
> https://meta.stackexchange.com/questions/353983/goodbye-prettify-hello-highlight-js-swapping-out-our-syntax-highlighter).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
