gnodet commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1720809744
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -874,9 +873,17 @@ private static <T> List<T> reverse(List<T> list) {
}
private List<File> parseExtClasspath(CliRequest cliRequest) {
- String extClassPath =
cliRequest.userProperties.getProperty(EXT_CLASS_PATH);
+ String extClassPath =
cliRequest.userProperties.getProperty(Constants.MAVEN_EXT_CLASS_PATH);
if (extClassPath == null) {
- extClassPath =
cliRequest.systemProperties.getProperty(EXT_CLASS_PATH);
+ extClassPath =
cliRequest.systemProperties.getProperty(Constants.MAVEN_EXT_CLASS_PATH);
+ if (extClassPath != null) {
+ slf4jLogger.warn(
+ "The property {} has been set using a JVM system
property which is deprecated. "
+ + "The property can be passed as a maven
argument or in the maven project configuration file,"
+ + "usually located at {}.",
+ Constants.MAVEN_EXT_CLASS_PATH,
+ "[rootDirectory]/.mvn/maven.properties");
Review Comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
