[
https://issues.apache.org/jira/browse/MNG-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873253#comment-17873253
]
ASF GitHub Bot commented on MNG-8210:
-------------------------------------
desruisseaux commented on code in PR #1651:
URL: https://github.com/apache/maven/pull/1651#discussion_r1715575464
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilder.java:
##########
@@ -25,7 +25,11 @@
public interface ModelBuilder extends Service {
- List<String> VALID_MODEL_VERSIONS = List.of("4.0.0", "4.1.0");
+ String MODEL_VERSION_4_0_0 = "4.0.0";
+
+ String MODEL_VERSION_4_1_0 = "4.0.0";
Review Comment:
Typo? Shouldn't the value be "4.1.0"?
> Rename maven module to subproject and make them optional in the POM
> -------------------------------------------------------------------
>
> Key: MNG-8210
> URL: https://issues.apache.org/jira/browse/MNG-8210
> Project: Maven
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-beta-4
>
>
> The maven "module" term is used to actually refer to subproject (since those
> are loaded as MavenProject, or Project in the v4 api). The only reference to
> "module" is in the POM really, so it would make sense to rename to
> {{subproject}} instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
