desruisseaux commented on code in PR #1640: URL: https://github.com/apache/maven/pull/1640#discussion_r1714881957
########## api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java: ########## @@ -23,76 +23,83 @@ import org.apache.maven.api.annotations.Nonnull; /** - * An artifact points to a resource such as a jar file or war application. + * Pointer to a resolved resource such as a <abbr>JAR</abbr> file or <abbr>WAE</abbr> application. Review Comment: I thought that "resolved" means that all properties were fixed to their final values, especially the version and obligation. Before resolution, an `ArtifactCoordinate` refers to an ensemble of files. After resolution, an `Artifact` refers to a single file. I was seeing the download as a separated concern. I have no problem in including download in the definition of "resolved", but maybe we should write this definition somewhere, e.g. in the package-info file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
