gnodet commented on PR #1638: URL: https://github.com/apache/maven/pull/1638#issuecomment-2284031732
> > So if you're targeting master, I'm not sure this PR is really needed. > > We are somehow going in cycles with this PR: @gnodet I think we agreed that even for Plugin Descriptor v2 the `requirements` is still evaluated! That means it should be marked as deprecated in both 1.1 and 2.0! I am gonna fix the version in this PR as well for `requirements`, but you should go over all other elements as well! As you've found out, it's not in the generated xml schema for v2. I don't see how it could be supported with the v2 schema without removing the DI support and restoring plexus. > Regarding > > > the deprecation message is plain wrong (mvn4 API has DI annotation, and not JSR330 is to be used) > > I am gonna clarify that in the deprecation that this is not necessarily JSR 330 annotation but alternatively some other annotation evaluated at run time. If you consider the XML the API, you can't bind to the implementation. Why are we talking about JSR330 annotations or `@Component` if that's the case ? > > > Am unsure is this PR really needed. > > For me the plugin descriptor is the primary contract between a plugin and Maven, and therefore it needs to be formally deprecated there before we can ultimately get rid of it in the future! It's fine to add the deprecation to the 1.1 model imho. Both 1.1 and 2.0 are supported by Maven 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
