gnodet commented on code in PR #1628:
URL: https://github.com/apache/maven/pull/1628#discussion_r1713790718
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java:
##########
@@ -324,7 +325,8 @@ private void doExecute2(MavenSession session, MojoExecution
mojoExecution) throw
} catch (MojoFailureException
| PluginManagerException
| PluginConfigurationException
- | MojoExecutionException e) {
+ | MojoExecutionException
+ | MojoException e) {
Review Comment:
Yes, but the intent is that the code either calls `MojoSucceeded` or
`MojoFailed`. Since any `MavenException` can be thrown at this point, they
need to be caught imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
