[
https://issues.apache.org/jira/browse/MBUILDCACHE-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872889#comment-17872889
]
ASF GitHub Bot commented on MBUILDCACHE-96:
-------------------------------------------
cstamas commented on code in PR #171:
URL:
https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713592139
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -684,51 +801,58 @@ private SortedMap<String, String>
getMutableDependenciesHashes(String keyPrefix,
projectInputCalculator.calculateInput(dependencyProject).getChecksum();
} else // this is a snapshot dependency
{
- DigestItem resolved =
resolveArtifact(repoSystem.createDependencyArtifact(dependency), false);
+ DigestItem resolved = null;
+ try {
+ resolved = resolveArtifact(dependency);
+ } catch (ArtifactResolutionException |
InvalidVersionSpecificationException e) {
+ throw new IOException(e);
+ }
projectHash = resolved.getHash();
}
result.put(
- keyPrefix +
KeyUtils.getVersionlessArtifactKey(repoSystem.createDependencyArtifact(dependency)),
- projectHash);
+ keyPrefix +
KeyUtils.getVersionlessArtifactKey(createDependencyArtifact(dependency)),
projectHash);
}
return result;
}
@Nonnull
- private DigestItem resolveArtifact(final Artifact dependencyArtifact,
boolean isOffline) throws IOException {
- ArtifactResolutionRequest request = new ArtifactResolutionRequest()
- .setArtifact(dependencyArtifact)
- .setResolveRoot(true)
- .setResolveTransitively(false)
- .setLocalRepository(session.getLocalRepository())
- .setRemoteRepositories(project.getRemoteArtifactRepositories())
- .setOffline(session.isOffline() || isOffline)
- .setForceUpdate(session.getRequest().isUpdateSnapshots())
- .setServers(session.getRequest().getServers())
- .setMirrors(session.getRequest().getMirrors())
- .setProxies(session.getRequest().getProxies());
-
- final ArtifactResolutionResult result = repoSystem.resolve(request);
-
- if (!result.isSuccess()) {
+ private DigestItem resolveArtifact(final Dependency dependency)
+ throws IOException, ArtifactResolutionException,
InvalidVersionSpecificationException {
Review Comment:
nit: who throws this? InvalidVersionSpecificationException
> Remove usage of maven-compat
> ----------------------------
>
> Key: MBUILDCACHE-96
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-96
> Project: Maven Build Cache Extension
> Issue Type: Task
> Affects Versions: 1.2.0
> Reporter: Olivier Lamy
> Assignee: Olivier Lamy
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
