michael-o commented on code in PR #216:
URL: https://github.com/apache/maven-scm/pull/216#discussion_r1712988126


##########
maven-scm-plugin/pom.xml:
##########
@@ -228,7 +228,7 @@
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-plugin-plugin</artifactId>
+        <artifactId>maven-plugin-report-plugin</artifactId>

Review Comment:
   @kwin I move this to a profile for consistency reasons with others.



##########
maven-scm-plugin/pom.xml:
##########
@@ -228,7 +228,7 @@
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-plugin-plugin</artifactId>
+        <artifactId>maven-plugin-report-plugin</artifactId>

Review Comment:
   > For me is ok ... even more I would be happy to remove reporting profile at 
all everywhere.
   > 
   > We always should execute all reporting plugins not only in special profile
   
   This is a separate discussion. The reason is likely computational overhead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to