[
https://issues.apache.org/jira/browse/MNG-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872450#comment-17872450
]
ASF GitHub Bot commented on MNG-8192:
-------------------------------------
kwin opened a new pull request, #1637:
URL: https://github.com/apache/maven/pull/1637
coordinates
This fixes throwing NPE for version being null.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> DefaultArtifact constructor no longer accepts empty version
> -----------------------------------------------------------
>
> Key: MNG-8192
> URL: https://issues.apache.org/jira/browse/MNG-8192
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.6.3
> Reporter: Konrad Windszus
> Priority: Major
>
> Due to the change introduced in MNG-6705
> ([https://github.com/apache/maven/commit/53f04f03e3e58c75dcc791d557758357a6ec7983)]
> an empty version being passed to the constructor of {{DefaultArtifact}}
> leads to an {{IllegalArgumentException}}
>
> {code}
> java.lang.IllegalArgumentException: version can neither be null, empty nor
> blank
> at org.apache.commons.lang3.Validate.notBlank(Validate.java:454)
> at
> org.apache.maven.artifact.ArtifactUtils.notBlank(ArtifactUtils.java:107)
> at
> org.apache.maven.artifact.ArtifactUtils.toSnapshotVersion(ArtifactUtils.java:57)
> at
> org.apache.maven.artifact.DefaultArtifact.setBaseVersionInternal(DefaultArtifact.java:389)
> at
> org.apache.maven.artifact.DefaultArtifact.selectVersion(DefaultArtifact.java:506)
> at
> org.apache.maven.artifact.DefaultArtifact.selectVersionFromNewRangeIfAvailable(DefaultArtifact.java:494)
> at
> org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:106)
> at
> org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:86)
> {code}
> Prior to Maven 3.6.2 this was throwing no exception at all (only null version
> values were rejected).
>
> Although throwing an exception for an invalid version is probably fine it
> should rather be a {{InvalidArtifactRTException}} thrown for other mandatory
> but empty arguments in
> https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java#L165-L184
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
