[
https://issues.apache.org/jira/browse/MJLINK-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869572#comment-17869572
]
ASF GitHub Bot commented on MJLINK-84:
--------------------------------------
matriv opened a new pull request, #211:
URL: https://github.com/apache/maven-jlink-plugin/pull/211
Dependency to commons-lang3 has been removed earlier on, but still there
were usages of `StringUtils` & `SystemUtils` which lead to the plugin requiring
the dependency to be added explicitly when used.
Follows: https://github.com/apache/maven-jlink-plugin/pull/167
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> apache commons lang3 was removed but still required
> ---------------------------------------------------
>
> Key: MJLINK-84
> URL: https://issues.apache.org/jira/browse/MJLINK-84
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Marios Trivyzas
> Priority: Critical
>
> {{[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-jlink-plugin:3.2.0:jlink (default-jlink) on
> project jlink-jdk: Execution default-jlink of goal
> org.apache.maven.plugins:maven-jlink-plugin:3.2.0:jlink failed: A required
> class was missing while executing
> org.apache.maven.plugins:maven-jlink-plugin:3.2.0:jlink:
> org/apache/commons/lang3/SystemUtils}}
> {{[ERROR] -----------------------------------------------------}}
> {{[ERROR] realm =
> extension>org.apache.maven.plugins:maven-jlink-plugin:3.2.0}}
> {{[ERROR] strategy =
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy}}
> {{[ERROR] urls[0] =
> file:/Users/matriv/.m2/repository/org/apache/maven/plugins/maven-jlink-plugin/3.2.0/maven-jlink-plugin-3.2.0.jar}}
> {{[ERROR] urls[1] =
> file:/Users/matriv/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.4.2/maven-shared-utils-3.4.2.jar}}
> {{[ERROR] urls[2] =
> file:/Users/matriv/.m2/repository/org/apache/maven/maven-archiver/3.6.1/maven-archiver-3.6.1.jar}}
> {{[ERROR] urls[3] =
> file:/Users/matriv/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.26/plexus-interpolation-1.26.jar}}
> {{[ERROR] urls[4] =
> file:/Users/matriv/.m2/repository/org/codehaus/plexus/plexus-archiver/4.9.1/plexus-archiver-4.9.1.jar}}
> {{[ERROR] urls[5] =
> file:/Users/matriv/.m2/repository/org/codehaus/plexus/plexus-utils/4.0.0/plexus-utils-4.0.0.jar}}
> {{[ERROR] urls[6] =
> file:/Users/matriv/.m2/repository/org/codehaus/plexus/plexus-io/3.4.1/plexus-io-3.4.1.jar}}
> {{[ERROR] urls[7] =
> file:/Users/matriv/.m2/repository/org/apache/commons/commons-compress/1.25.0/commons-compress-1.25.0.jar}}
> {{[ERROR] urls[8] =
> file:/Users/matriv/.m2/repository/org/iq80/snappy/snappy/0.4/snappy-0.4.jar}}
> {{[ERROR] urls[9] =
> file:/Users/matriv/.m2/repository/org/tukaani/xz/1.9/xz-1.9.jar}}
> {{[ERROR] urls[10] =
> file:/Users/matriv/.m2/repository/com/github/luben/zstd-jni/1.5.5-11/zstd-jni-1.5.5-11.jar}}
> {{[ERROR] urls[11] =
> file:/Users/matriv/.m2/repository/org/codehaus/plexus/plexus-java/1.2.0/plexus-java-1.2.0.jar}}
> {{[ERROR] urls[12] =
> file:/Users/matriv/.m2/repository/org/ow2/asm/asm/9.6/asm-9.6.jar}}
> {{[ERROR] urls[13] =
> file:/Users/matriv/.m2/repository/com/thoughtworks/qdox/qdox/2.0.3/qdox-2.0.3.jar}}
> {{[ERROR] urls[14] =
> file:/Users/matriv/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar}}
> {{[ERROR] Number of foreign imports: 1}}
> {{[ERROR] import: Entry[import from realm ClassRealm[maven.api, parent:
> null]]}}
> {{[ERROR]}}
> {{[ERROR] -----------------------------------------------------}}
> {{[ERROR] : org.apache.commons.lang3.SystemUtils}}
> {{[ERROR] -> }}
> {{[Help 1]}}
>
> {{apache commons lang3 dependency was removed with:
> https://github.com/apache/maven-jlink-plugin/pull/167}}
> {{but is still being used by:
> https://github.com/apache/maven-jlink-plugin/blob/master/src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java#L45}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
