[
https://issues.apache.org/jira/browse/MPLUGIN-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869404#comment-17869404
]
ASF GitHub Bot commented on MPLUGIN-529:
----------------------------------------
mattnelson commented on code in PR #310:
URL:
https://github.com/apache/maven-plugin-tools/pull/310#discussion_r1695539089
##########
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReportNoFork.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugin.plugin.report;
+
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+
+/**
+ * Generates the Plugin's documentation report: <code>plugin-info.html</code>
plugin overview page,
+ * and one <code><i>goal</i>-mojo.html</code> per goal.
+ * Relies on one output file from <a
href="../maven-plugin-plugin/descriptor-mojo.html">plugin:descriptor</a>.
+ *
+ * @since 3.14.0
Review Comment:
3.x is currently 3.13.2, but I would expect a new goal to be first include
in a minor version instead.
https://github.com/apache/maven-plugin-tools/blob/ad93285f66b95cfe186ee83f53e4e520241eee35/pom.xml#L32
##########
maven-plugin-report-plugin/src/it/mplugin-529_nofork/verify.groovy:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+assert new File( basedir, 'target/site/report-mojo.html' ).isFile()
+
+def pluginInfo = new File( basedir, 'target/site/plugin-info.html' )
+assert pluginInfo.isFile()
+
+assert !pluginInfo.text.contains('Memory')
+assert !pluginInfo.text.contains('Disk Space')
+// check JDK and Maven requirements
+assert pluginInfo.text.contains('1.8')
+assert pluginInfo.text.contains('3.9.6')
+
+// deprecated info and description
+assert pluginInfo.text.contains('<div><strong>Deprecated.</strong> You don\'t
use test goals, do you?</div><br />')
+assert pluginInfo.text.contains('Does nothing.')
+
+assert new File( basedir, 'target/site/de/noop-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/de/report-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/de/plugin-info.html' ).isFile()
+
+assert new File( basedir, 'target/site/fr/noop-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/fr/report-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/fr/plugin-info.html' ).isFile()
+
+def noopMojo = new File( basedir, 'target/site/noop-mojo.html' )
+assert noopMojo.isFile()
+
+// deprecated in table and details
+assert noopMojo.text.count('<div><strong>Deprecated.</strong><br />Just
testing.</div><br />') == 2
+
+assert 1 == new File( basedir, 'build.log' ).text.count('Always pass!');
Review Comment:
This IT was copied from `plugin-report`, then updated with this assertion
and corresponding POM changes to make the build no longer fork.
> New goals report-no-fork which will not invoke process-classes
> --------------------------------------------------------------
>
> Key: MPLUGIN-529
> URL: https://issues.apache.org/jira/browse/MPLUGIN-529
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Reporting Plugin
> Reporter: Matt Nelson
> Priority: Major
>
> Identical root issues as MJAVADOC-369 and JXR-143
> Add new goal which does not fork the build when those phases have already
> executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
