[
https://issues.apache.org/jira/browse/MSITE-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869181#comment-17869181
]
ASF GitHub Bot commented on MSITE-945:
--------------------------------------
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-site-plugin/pull/203#discussion_r1694281060
##########
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##########
@@ -51,15 +53,18 @@
@RunWith(JUnit4.class)
public abstract class AbstractSiteDeployWebDavTest extends
AbstractMojoTestCase {
- File siteTargetPath = new File(getBasedir() + File.separator + "target" +
File.separator + "siteTargetDeploy");
+ @Rule
+ public TemporaryFolder folder = new TemporaryFolder();
+
+ private File siteTargetPath;
@Override
@Before
public void setUp() throws Exception {
super.setUp();
+ siteTargetPath = new File(new File(folder.newFolder(), "target"),
"siteTargetDeploy");
Review Comment:
Both target and siteTargetDeploy are superfluous now.
> Remove dependency on Commons IO
> -------------------------------
>
> Key: MSITE-945
> URL: https://issues.apache.org/jira/browse/MSITE-945
> Project: Maven Site Plugin
> Issue Type: Dependency upgrade
> Reporter: Elliotte Rusty Harold
> Priority: Major
> Labels: up-for-grabs
>
> All uses look easily replaceable by standard JDK methods these days
--
This message was sent by Atlassian Jira
(v8.20.10#820010)