michael-o commented on code in PR #15:
URL:
https://github.com/apache/maven-apache-resources/pull/15#discussion_r1676346741
##########
source-release/src/test/java/org/apache/its/util/TestUtils.java:
##########
@@ -32,13 +32,27 @@
import java.util.zip.ZipFile;
import org.apache.commons.compress.archivers.ArchiveEntry;
+import org.apache.maven.it.VerificationException;
+import org.apache.maven.it.Verifier;
import org.codehaus.plexus.archiver.tar.GZipTarFile;
import static junit.framework.Assert.assertTrue;
import static junit.framework.Assert.fail;
public class TestUtils {
+ private static final String IT_REPO_LOCAL = "it.repo.local";
+
+ public static Verifier createVerifier(File testDir) throws
VerificationException {
+ Verifier verifier = new Verifier(testDir.getAbsolutePath());
+ // use custom local repository (workaround for
https://issues.apache.org/jira/browse/SUREFIRE-1385)
Review Comment:
This should have a "TODO"
##########
source-release/pom.xml:
##########
@@ -135,9 +135,11 @@ under the License.
<name>maven.home</name>
<value>${preparedMavenHome}</value>
</property>
+ <!-- cannot use property "maven.repo.local" as already
used on as user property on the CLI through ASF Jenkins,
Review Comment:
Should have a TODO/FIXME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
