[
https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864625#comment-17864625
]
ASF GitHub Bot commented on MNG-7914:
-------------------------------------
michael-o commented on code in PR #1595:
URL: https://github.com/apache/maven/pull/1595#discussion_r1672113492
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##########
@@ -57,13 +57,13 @@ public class DefaultToolchainsBuilder implements
ToolchainsBuilder {
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException {
List<BuilderProblem> problems = new ArrayList<>();
- Source globalSource = request.getGlobalToolchainsSource().orElse(null);
- PersistedToolchains global = readToolchains(globalSource, request,
problems);
+ Source installSource =
request.getInstallationToolchainsSource().orElse(null);
Review Comment:
Same here
##########
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -358,10 +359,7 @@ public void close() {
private int getParallelism(ProjectBuildingRequest request) {
int parallelism = DEFAULT_BUILDER_PARALLELISM;
try {
- String str =
request.getUserProperties().getProperty(BUILDER_PARALLELISM);
- if (str == null) {
- str =
request.getSystemProperties().getProperty(BUILDER_PARALLELISM);
- }
+ String str =
request.getUserProperties().getProperty(Constants.MAVEN_PROJECT_BUILDER_PARALLELISM);
Review Comment:
Very good, less dependence on system properties
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java:
##########
@@ -70,7 +67,6 @@ public MavenBuildTimestamp(Instant time, String
timestampFormat) {
}
SimpleDateFormat dateFormat = new SimpleDateFormat(timestampFormat);
dateFormat.setCalendar(new GregorianCalendar());
- dateFormat.setTimeZone(DEFAULT_BUILD_TIME_ZONE);
Review Comment:
Attention, this is a semantic change. We should retain `Etc/UTC` and maybe
make it configurable in the future.
##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultSettingsBuilder.java:
##########
@@ -66,8 +66,8 @@ public class DefaultSettingsBuilder implements
SettingsBuilder {
public SettingsBuilderResult build(SettingsBuilderRequest request) throws
SettingsBuilderException {
List<BuilderProblem> problems = new ArrayList<>();
- Source globalSource = request.getGlobalSettingsSource().orElse(null);
- Settings global = readSettings(globalSource, false, request, problems);
+ Source installSource =
request.getInstallationSettingsSource().orElse(null);
Review Comment:
`installationSource`
> Provide a single entry point for configuration
> ----------------------------------------------
>
> Key: MNG-7914
> URL: https://issues.apache.org/jira/browse/MNG-7914
> Project: Maven
> Issue Type: New Feature
> Reporter: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Looking at MNG-7772, this should not require any code change, but it's all
> about configuration.
> I propose to load / interpolate the following files:
> * {{${maven.home}/conf/maven.user.properties}}
> * {{${maven.home}/conf/maven.system.properties}}
> Those files would be used to load additional user properties and system
> properties for Maven. In addition to the simple interpolation mechanism, we
> should provide two enhancements using special keys {{{}$\{includes{}}}} and
> {{{}$\{optionals{}}}} which would be used to load additional referenced
> configuration files such as:
> {{ ${optionals} = ${user.home}/.m2/maven.user.properties,
> ${session.rootDirectory}/.mvn/maven.user.properties}}
> Being loaded early when Maven is loaded, those files could reference
> directories to load extensions from:
> {{{}maven.core.extensions.directories =
> ${session.rootDirectory}/.mvn/extensions.xml,{}}}{{{}${user.home}/.m2/extensions.xml,${maven.home}/extensions.xml{}}}
>
> In various places, the maven code could be simplified and offer more
> configuration points at the same time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
