gnodet commented on PR #1603:
URL: https://github.com/apache/maven/pull/1603#issuecomment-2220223977

   > @slawekjaranowski DefaultProfileActivationContext.setSystemProperties 
allows empty/null system properties (the default value if setSystemProperties 
isn't called is an empty map, too). Moreover, I don't think we can make any 
assumptions on "os.name", etc., to be available.
   > 
   > As to where this from: I've added an exception to 
`DefaultProfileActivationContext` that checks for empty property maps, and this 
is what I get
   > 
   > ```
   >     at 
org.apache.maven.model.profile.DefaultProfileActivationContext.setSystemProperties
 (DefaultProfileActivationContext.java:108)
   >     at 
org.apache.maven.model.building.DefaultModelBuilder.getProfileActivationContext 
(DefaultModelBuilder.java:661)
   >     at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:265)
   >     at org.apache.maven.model.building.DefaultModelBuilder.build 
(DefaultModelBuilder.java:247)
   >     at org.apache.maven.project.DefaultProjectBuilder.build 
(DefaultProjectBuilder.java:176)
   >     at org.apache.maven.project.DefaultProjectBuilder.build 
(DefaultProjectBuilder.java:123)
   >     at 
org.apache.maven.report.projectinfo.ModulesReport$ModulesRenderer.renderBody 
(ModulesReport.java:174)
   >     at org.apache.maven.reporting.AbstractMavenReportRenderer.render 
(AbstractMavenReportRenderer.java:82)
   >     at org.apache.maven.report.projectinfo.ModulesReport.executeReport 
(ModulesReport.java:75)
   >     at org.apache.maven.reporting.AbstractMavenReport.generate 
(AbstractMavenReport.java:289)
   >     at 
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument 
(ReportDocumentRenderer.java:198)
   >     at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render 
(DefaultSiteRenderer.java:298)
   >     at 
org.apache.maven.plugins.site.render.SiteMojo.renderNonDoxiaDocuments 
(SiteMojo.java:280)
   >     at org.apache.maven.plugins.site.render.SiteMojo.renderLocale 
(SiteMojo.java:162)
   >     at org.apache.maven.plugins.site.render.SiteMojo.execute 
(SiteMojo.java:115)
   >     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:126)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
(MojoExecutor.java:328)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
(MojoExecutor.java:316)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:212)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:174)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
(MojoExecutor.java:75)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
(MojoExecutor.java:162)
   >     at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
(DefaultMojosExecutionStrategy.java:39)
   >     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:159)
   >     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:105)
   >     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:73)
   >     at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:53)
   >     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:118)
   >     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
   >     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
   >     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
   >     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
   >     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
   >     at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
   >     at jdk.internal.reflect.DirectMethodHandleAccessor.invoke 
(DirectMethodHandleAccessor.java:103)
   >     at java.lang.reflect.Method.invoke (Method.java:580)
   >     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:255)
   >     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:201)
   >     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:361)
   >     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:314)
   > ```
   
   The assumption is not `context.getSystemProperties()` returns... system 
properties.  So imho, the PR is wrong and it means the caller does not set the 
system properties correctly.  In Maven itself, the only place is in 
`DefaultModelBuilder`, where properties are set correctly afaik.  So the bug is 
that the system properties are not correctly set on the request:
   
https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/ModulesReport.java#L160-L162
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to