slawekjaranowski commented on code in PR #1605:
URL: https://github.com/apache/maven/pull/1605#discussion_r1671730082


##########
maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsXmlFactory.java:
##########
@@ -53,10 +52,6 @@ public PersistedToolchains read(@Nonnull XmlReaderRequest 
request) throws XmlRea
             throw new IllegalArgumentException("reader or inputStream must be 
non null");
         }
         try {
-            InputSource source = null;
-            if (request.getModelId() != null || request.getLocation() != null) 
{
-                source = new InputSource(request.getModelId(), 
request.getLocation());
-            }

Review Comment:
   Yes new rule was detected it.
   @gnodet - why is not used here ....?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to