gnodet commented on code in PR #1604:
URL: https://github.com/apache/maven/pull/1604#discussion_r1671259494


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -320,12 +320,14 @@ void initialize(CliRequest cliRequest) throws 
ExitException {
         // We need to locate the top level project which may be pointed at 
using
         // the -f/--file option.  However, the command line isn't parsed yet, 
so
         // we need to iterate through the args to find it and act upon it.
-        Path topDirectory = Paths.get(cliRequest.workingDirectory);
+        Path cwd = Paths.get(cliRequest.workingDirectory);
+        // MavenCliTest extensively uses MULTIMODULE_PROJECT_DIRECTORY
+        Path topDirectory = cliRequest.multiModuleProjectDirectory.toPath();

Review Comment:
   In addition, having everything depending on a system property which is set 
externally, and thus, out of control, is a bad idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to