slachiewicz commented on code in PR #20:
URL: 
https://github.com/apache/maven-jarsigner-plugin/pull/20#discussion_r1667633959


##########
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##########
@@ -346,6 +350,23 @@ private List<File> findJarfiles() throws 
MojoExecutionException {
         return archives;
     }
 
+    /**
+     * {@linkplain Path#relativize(Path) Relativizes} the path against {@link 
MavenProject#getBasedir()}.
+     * Can be used to shorten or simplify paths before displaying them to the 
user.
+     */
+    private Path relativizePathAgainstBasedir(Path path) {

Review Comment:
   This will not have best performance, as You calculate base dir for every file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to