belingueres commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1637256257
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##########
@@ -591,16 +595,75 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}
- tableRow(hasSealed, new String[] {
- name,
- fileLength,
- String.valueOf(jarDetails.getNumEntries()),
- String.valueOf(jarDetails.getNumClasses()),
- String.valueOf(jarDetails.getNumPackages()),
- jdkRevisionCellValue,
- debugInformationCellValue,
- sealedCellValue
- });
+ if (jarDetails.isMultiRelease()) {
+ String htmlBullet = "   • ";
+ String rootTag = htmlBullet +
getI18nString("file.details.multirelease.root");
+ String versionedTag = htmlBullet +
getI18nString("file.details.multirelease.versioned");
+
+ // general jar information row
+ tableRow(hasSealed, new String[] {
+ name,
+ fileLength,
+ String.valueOf(jarDetails.getNumEntries()),
+ "",
+ "",
Review Comment:
I prefer to omit them, since the getNumClasses() and getNumPackages() are
already asociated to the root content. In addition, we cannot sum over the root
class/package names with the versioned class/package names because some of them
will be in more than one place, so putting a "total" in the first row seems
somewhat inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
