slawekjaranowski commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1635970698


##########
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##########
@@ -160,7 +160,9 @@ public DependencyResolutionResult 
resolve(DependencyResolutionRequest request)
             result.setCollectionErrors(e.getResult().getExceptions());
 
             throw new DependencyResolutionException(
-                    result, "Could not resolve dependencies for project " + 
project.getId() + ": " + e.getMessage(), e);
+                    result,
+                    "Could not collect dependencies for project " + 
project.getId(),
+                    logger.isDebugEnabled() ? e : null);

Review Comment:
   without passing exception (current proposition) we will have:
   ```
   [ERROR] Failed to execute goal on project test: Could not resolve 
dependencies for project org.apache.maven.its.mng3477:test:jar:1
   [ERROR] dependency: org.apache.maven.its.mng3477:dep:jar:1.0 (compile)
   [ERROR]      Could not find artifact 
org.apache.maven.its.mng3477:dep:jar:1.0 in maven-core-it 
(http://localhost:64468/repo)
   [ERROR]      Could not find artifact 
org.apache.maven.its.mng3477:dep:jar:1.0 in central 
(http://localhost:64468/repo)
   [ERROR] -> [Help 1]
   ```
   
   with exception will be as:
   
   ```
   [ERROR] Failed to execute goal on project test: Could not resolve 
dependencies for project org.apache.maven.its.mng3477:test:jar:1
   [ERROR] dependency: org.apache.maven.its.mng3477:dep:jar:1.0 (compile)
   [ERROR]      Could not find artifact 
org.apache.maven.its.mng3477:dep:jar:1.0 in central 
(http://localhost:64398/repo)
   [ERROR]      Could not find artifact 
org.apache.maven.its.mng3477:dep:jar:1.0 in maven-core-it 
(http://localhost:64398/repo): The following artifacts could not be resolved: 
org.apache.maven.its.mng3477:dep:jar:1.0 (absent): Could not find artifact 
org.apache.maven.its.mng3477:dep:jar:1.0 in central 
(http://localhost:64398/repo)
   [ERROR] -> [Help 1]
   ```
   
   so it is a reason 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to