[
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854133#comment-17854133
]
ASF GitHub Bot commented on MPIR-455:
-------------------------------------
michael-o commented on code in PR #70:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1635270543
##########
pom.xml:
##########
@@ -511,11 +511,47 @@ under the License.
<pomExclude>pom.xml</pomExclude>
</pomExcludes>
<localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
+ <filterProperties>
+
<repository.proxy.url>${repository.proxy.url}</repository.proxy.url>
+ </filterProperties>
+ <addTestClassPath>true</addTestClassPath>
+
<goals>
<goal>site</goal>
</goals>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>mrm-maven-plugin</artifactId>
+ <version>1.6.0</version>
+ <configuration>
+ <propertyName>repository.proxy.url</propertyName>
+ <repositories>
+ <mockRepo>
+ <source>src/it/mrm/repository</source>
+ <!--
Review Comment:
Using the plugin is totally fine, I do not object. I was solely referring
that the comment bears the JIRA issue id. If more ITs will use it, the comment
won't be accurate anymore.
##########
pom.xml:
##########
@@ -511,11 +511,47 @@ under the License.
<pomExclude>pom.xml</pomExclude>
</pomExcludes>
<localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
+ <filterProperties>
+
<repository.proxy.url>${repository.proxy.url}</repository.proxy.url>
+ </filterProperties>
+ <addTestClassPath>true</addTestClassPath>
Review Comment:
Then drop it.
> dependencies goal: add support for multi-release JARs
> -----------------------------------------------------
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: dependencies
> Affects Versions: 3.4.5, 3.5.0
> Reporter: Gabriel Belingueres
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png,
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png,
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
