reda-alaoui commented on code in PR #146:
URL:
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1633569241
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws
IOException {
}
private SortedMap<String, String> getMutableDependencies() throws
IOException {
+ return getMutableDependenciesHashes("", project.getDependencies());
+ }
+
+ private SortedMap<String, String> getMutablePluginDependencies() throws
IOException {
+ SortedMap<String, String> fullMap = new TreeMap<>();
+ for (Plugin plugin : project.getBuildPlugins()) {
+ if (config.isPluginDependenciesExcluded(plugin)) {
+ continue;
+ }
+ fullMap.putAll(getMutableDependenciesHashes(
+
KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) +
"|",
Review Comment:
To keep `compareWithBaseline` feature operational with plugin dependencies,
I added an occurrency index to the map key instead of turning the map into a
collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
