romani commented on code in PR #141: URL: https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1633357951
########## src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java: ########## @@ -26,22 +26,24 @@ import java.io.OutputStream; import java.nio.file.Path; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.Locale; import java.util.Map; +import com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions; Review Comment: With a strive to cover as much people as possible, we will force all of them to understand that plugin is not compatible with [10.9.3, 10.17.0], it is a lot of versions. People need some specific versions to match behavior in Eclipse and in Sonar. If we want full happiness of users we need to put in plugin code that is aware of problems in Ctors and use ctor only if it exists. We will remove deprecated class when we do major version bump or something big. But again maybe it is better to break compatibility sooner. Breaking changes are inevitable, it is just just question on to do it sooner or later, but user pain will be the same. As you already do huge non compatible changes, it might be good to make it clear that this version is up to checkstyle 10.9.2 . And next version of plugin will be 10.9.3 and up. So we will remove deprecated class and users will not notice it. So next big update for plugin will be migration to jdk17, whenever maven team decides to go this. But users will use plugin at jdk21 with all latest updates to validate fancy modern syntax of java . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
