michael-o commented on PR #406:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/406#issuecomment-2150966364

   I have the reason and the reason is valid and I believe that 
0bb4c5917222c4f4a6df53bbc70dd770507a3d4d must be reverted.
   The goal is called `resolve`, the other one should have been called 
`resolve-sources`. The source code clearly says:
   ```
               // dependencies:collect won't download jars
               if (artifact.getFile() != null) {
                   ModuleDescriptor moduleDescriptor = 
getModuleDescriptor(artifact.getFile());
                   if (moduleDescriptor != null) {
                       messageBuilder.project(" -- module " + 
moduleDescriptor.name);
   
                       if (moduleDescriptor.automatic) {
                           if 
("MANIFEST".equals(moduleDescriptor.moduleNameSource)) {
                               messageBuilder.strong(" [auto]");
                           } else {
                               messageBuilder.warning(" (auto)");
                           }
                       }
                   }
               }
   ```
   So we need `collect-sources` maybe as well. I am inclined to close MDEP-900 
as wontfix and revert MDEP-895.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to