[
http://jira.codehaus.org/browse/WAGON-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104145
]
Brian Fox edited comment on WAGON-73 at 8/6/07 8:33 PM:
--------------------------------------------------------
I ran the ITs using Maven 2.0.7 and I get one additional failure with the patch
applied:
{noformat}
testSnapshotLocalMetadataUpdatedOnInstall(org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest)
{noformat}
The ones that fail regardless of the patch or not are:
{noformat}
Failed tests:
testit0002(org.apache.maven.integrationtests.MavenIT0002Test)
testit0008(org.apache.maven.integrationtests.MavenIT0008Test)
testit0009(org.apache.maven.integrationtests.MavenIT0009Test)
testit0012(org.apache.maven.integrationtests.MavenIT0012Test)
testit0022(org.apache.maven.integrationtests.MavenIT0022Test)
testit0023(org.apache.maven.integrationtests.MavenIT0023Test)
testit0025(org.apache.maven.integrationtests.MavenIT0025Test)
testit0026(org.apache.maven.integrationtests.MavenIT0026Test)
testit0027(org.apache.maven.integrationtests.MavenIT0027Test)
testit0040(org.apache.maven.integrationtests.MavenIT0040Test)
testit0041(org.apache.maven.integrationtests.MavenIT0041Test)
testit0044(org.apache.maven.integrationtests.MavenIT0044Test)
testit0045(org.apache.maven.integrationtests.MavenIT0045Test)
testit0046(org.apache.maven.integrationtests.MavenIT0046Test)
testit0049(org.apache.maven.integrationtests.MavenIT0049Test)
testit0064(org.apache.maven.integrationtests.MavenIT0064Test)
testit0071(org.apache.maven.integrationtests.MavenIT0071Test)
testit0073(org.apache.maven.integrationtests.MavenIT0073Test)
testit0082(org.apache.maven.integrationtests.MavenIT0082Test)
testit0088(org.apache.maven.integrationtests.MavenIT0088Test)
testit0090(org.apache.maven.integrationtests.MavenIT0090Test)
Tests in error:
testit0086(org.apache.maven.integrationtests.MavenIT0086Test)
testit0087(org.apache.maven.integrationtests.MavenIT0087Test)
testit0104(org.apache.maven.integrationtests.MavenIT0104Test)
Tests run: 115, Failures: 21, Errors: 3, Skipped: 0
{noformat}
The error for this test is:
{noformat}
testSnapshotLocalMetadataUpdatedOnInstall(org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest)
Time elapsed: 3.5 sec <<< FAILURE!
junit.framework.ComparisonFailure: expected:<...6...> but was:<...7...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at
org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest.assertLocalMetadataIsToday(MavenIT0108SnapshotUpdateTest.java:243)
at
org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest.testSnapshotLocalMetadataUpdatedOnInstall(MavenIT0108SnapshotUpdateTest.java:215)
at
org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest.testSnapshotLocalMetadataUpdatedOnInstall(MavenIT0108SnapshotUpdateTest.java:215)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:154)
{noformat}
was:
I ran the ITs using Maven 2.0.7 and I get one additional failure with the patch
applied:
{noformat}
testSnapshotLocalMetadataUpdatedOnInstall(org.apache.maven.integrationtests.MavenIT0108SnapshotUpdateTest)
{noformat}
The ones that fail regardless of the patch or not are:
{noformat}
Failed tests:
testit0002(org.apache.maven.integrationtests.MavenIT0002Test)
testit0008(org.apache.maven.integrationtests.MavenIT0008Test)
testit0009(org.apache.maven.integrationtests.MavenIT0009Test)
testit0012(org.apache.maven.integrationtests.MavenIT0012Test)
testit0022(org.apache.maven.integrationtests.MavenIT0022Test)
testit0023(org.apache.maven.integrationtests.MavenIT0023Test)
testit0025(org.apache.maven.integrationtests.MavenIT0025Test)
testit0026(org.apache.maven.integrationtests.MavenIT0026Test)
testit0027(org.apache.maven.integrationtests.MavenIT0027Test)
testit0040(org.apache.maven.integrationtests.MavenIT0040Test)
testit0041(org.apache.maven.integrationtests.MavenIT0041Test)
testit0044(org.apache.maven.integrationtests.MavenIT0044Test)
testit0045(org.apache.maven.integrationtests.MavenIT0045Test)
testit0046(org.apache.maven.integrationtests.MavenIT0046Test)
testit0049(org.apache.maven.integrationtests.MavenIT0049Test)
testit0064(org.apache.maven.integrationtests.MavenIT0064Test)
testit0071(org.apache.maven.integrationtests.MavenIT0071Test)
testit0073(org.apache.maven.integrationtests.MavenIT0073Test)
testit0082(org.apache.maven.integrationtests.MavenIT0082Test)
testit0088(org.apache.maven.integrationtests.MavenIT0088Test)
testit0090(org.apache.maven.integrationtests.MavenIT0090Test)
Tests in error:
testit0086(org.apache.maven.integrationtests.MavenIT0086Test)
testit0087(org.apache.maven.integrationtests.MavenIT0087Test)
testit0104(org.apache.maven.integrationtests.MavenIT0104Test)
Tests run: 115, Failures: 21, Errors: 3, Skipped: 0
{noformat}
> MirroredWagon infinite loop
> ---------------------------
>
> Key: WAGON-73
> URL: http://jira.codehaus.org/browse/WAGON-73
> Project: wagon
> Issue Type: Bug
> Reporter: Phillip Webb
> Priority: Critical
> Fix For: 2.0
>
> Attachments: returnsonmirroredwagon.patch,
> WAGON-73-ConnectAndGetTest.patch, WagonManagerTest.java.patch
>
>
> The MirroredWagon class includes a get method that runs into an infinite loop.
> I think a return is required after this.impl.get( resource, destination );
> public void get( String resource, File destination )
> throws TransferFailedException, ResourceDoesNotExistException,
> AuthorizationException
> {
> try
> {
> while ( true )
> {
> try
> {
> this.impl.get( resource, destination );
> }
> catch ( TransferFailedException e )
> {
> nextMirror();
> }
> }
> }
> catch ( ExhaustedMirrorsException e )
> {
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
