[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849276#comment-17849276
]
ASF GitHub Bot commented on MPMD-395:
-------------------------------------
adangel commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1613377842
##########
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##########
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
+
+import net.sourceforge.pmd.cpd.CPDReport;
+import net.sourceforge.pmd.cpd.CPDReportRenderer;
+import net.sourceforge.pmd.cpd.Match;
+import net.sourceforge.pmd.cpd.XMLRenderer;
+import org.apache.maven.plugins.pmd.ExcludeDuplicationsFromFile;
+import org.apache.maven.reporting.MavenReportException;
+import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CpdReportConsumer implements Consumer<CPDReport> {
+ private static final Logger LOG =
LoggerFactory.getLogger(CpdReportConsumer.class);
+
+ private final CpdRequest request;
+ private final ExcludeDuplicationsFromFile excludeDuplicationsFromFile;
+ private MavenReportException reportException;
+
+ CpdReportConsumer(CpdRequest request, ExcludeDuplicationsFromFile
excludeDuplicationsFromFile) {
+ this.request = request;
+ this.excludeDuplicationsFromFile = excludeDuplicationsFromFile;
+ }
+
+ @Override
+ public void accept(CPDReport report) {
+ try {
+ // always create XML format. we need to output it even if the file
list is empty or we have no
+ // duplications so that the "check" goals can check for violations
+ writeXmlReport(report);
+
+ // html format is handled by maven site report, xml format has
already been rendered
+ // a renderer is only needed for other formats
+ String format = request.getFormat();
+ if (!"html".equals(format) && !"xml".equals(format)) {
+ writeFormattedReport(report);
+ }
+ } catch (MavenReportException e) {
+ // Exceptions happening during this consumer are only logged by
PMD.
+ // Remembering the exception here, so that we can rethrow it later
to fail the build.
+ reportException = e;
+ throw new RuntimeException(e);
Review Comment:
We need to use the `Consumer` interface here, as that's PMD's API for now.
I've done a different approach now: The exceptions happening during CPD
analysis (including when the report is written), are logged and can be
intercepted. I'm collecting them now via the logging facility and rethrow them
at the end.
> Build doesn't fail for invalid CPD format
> -----------------------------------------
>
> Key: MPMD-395
> URL: https://issues.apache.org/jira/browse/MPMD-395
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: CPD
> Affects Versions: 3.22.0
> Reporter: Andreas Dangel
> Assignee: Andreas Dangel
> Priority: Major
>
> See
> [https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392]
>
> If an exception occurs while the CPD report is created, the exception is only
> logged but doesn't fail the build. This means, that build appears to be
> successful, although it didn't produce all expected build artifacts.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
