[ 
https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847526#comment-17847526
 ] 

ASF GitHub Bot commented on MJAR-310:
-------------------------------------

jansohn commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118826793

   > @jansohn - please look at comments in JIRA 
https://issues.apache.org/jira/browse/MJAR-310
   > It can be reasonable to fix a bug in plexus-utils
   
   Makes sense but there are already three year old PRs trying to revert the 
extra use of cmd.exe so I'm not keen on going down that route.
   
   I think it makes more sense to just use ProcessBuilder directly for such a 
simple task.




> [REGRESSION] Plugin fails to handle toolchain paths that contain spaces
> -----------------------------------------------------------------------
>
>                 Key: MJAR-310
>                 URL: https://issues.apache.org/jira/browse/MJAR-310
>             Project: Maven JAR Plugin
>          Issue Type: Bug
>    Affects Versions: 3.4.0, 3.4.1
>         Environment: Maven 3.9.6
> Windows 10
>            Reporter: Gili
>            Priority: Major
>             Fix For: next-release
>
>
> When upgrading from version 3.3.0 to 3.4.0 I started getting the following 
> build-time warning:
>  
> {{[WARNING] Unrecognized output form C:\Program 
> Files\Java\zulu-8\bin\javac.exe -version - 'C:\Program' is not recognized as 
> an internal or external command,}}
> {{operable program or batch file.}}
>  
> The contents of toolchain.xml is:
>  
> {{<?xml version="1.0" encoding="UTF8"?>}}
> {{<toolchains>}}
> {{    <toolchain>}}
> {{        <type>jdk</type>}}
> {{        <provides>}}
> {{            <version>8</version>}}
> {{            <vendor>zulu</vendor>}}
> {{        </provides>}}
> {{        <configuration>}}
> {{            <jdkHome>C:\Program Files\Java\zulu-8</jdkHome>}}
> {{        </configuration>}}
> {{    </toolchain>}}
> {{</toolchains>}}
>  
> I don't know if this warning breaks anything.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to