elharo commented on code in PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#discussion_r1605514887
##########
src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java:
##########
@@ -1640,7 +1642,7 @@ private void runBuild(
}
} catch (RunFailureException e) {
buildJob.setResult(e.getType());
- buildJob.setFailureMessage(e.getMessage());
+
buildJob.setFailureMessage(StringEscapeUtils.escapeXml10(e.getMessage()));
Review Comment:
I probably need to pop the code open to figure this out. What is "buildJob"?
It's a org.apache.maven.plugins.invoker.model.BuildJob, right? If so, why does
it need escaped XML test instead of just plain text? I'd expect it to supply
unescaped strings to the writer which would then do any necessary escaping.
In line 1639 above, the message is not escaped. It should likely be escaped
in both or neither.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
