[
https://issues.apache.org/jira/browse/DOXIA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847430#comment-17847430
]
ASF GitHub Bot commented on DOXIA-737:
--------------------------------------
michael-o commented on PR #214:
URL: https://github.com/apache/maven-doxia/pull/214#issuecomment-2118248557
> BTW: There is no need for git commit messages which close the PR.. This is
only useful when referencing a GitHub issue.
I know, I do it on purpose to establish the connection between the commit
and the PR when browsing `git log` from the terminal. Metadata.
> [REGRESSION] Making EmitAnchorsForIndexableEntries by default does not
> extract document titles anymore
> ------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-737
> URL: https://issues.apache.org/jira/browse/DOXIA-737
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-M11
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Blocker
> Fix For: 2.0.0, 2.0.0-M12
>
>
> While working on https://github.com/apache/maven-site/pull/525 the following
> happens:
> Title before:
> {project} -- {document}
> Title now:
> {project}
> The document title is not extracted from the document anymore.
> If I do the following:
> {noformat}
> diff --git
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
>
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> index 544b6b9..b6a7d1d 100644
> ---
> a/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> +++
> b/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> @@ -330,7 +330,6 @@ public class DefaultSiteRenderer implements Renderer {
> if (!isConfigured) {
> // DOXIASITETOOLS-146 don't render comments from source
> markup
> parser.setEmitComments(false);
> - parser.setEmitAnchorsForIndexableEntries(true);
> }
> // TODO: DOXIA-111: the filter used here must be checked
> generally.
> {noformat}
> Everything works again. I bet that the {{SiteRendererSink}} does not work
> well with the new approach in Doxia.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
