[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843544#comment-17843544
]
ASF GitHub Bot commented on MSHARED-1390:
-----------------------------------------
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374
##########
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##########
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+ @Override
+ public InvocationRequest addArgs(Collection<String> args) {
+ args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
Should we really check for empty arg lines?
```
<args>
<arg> </arg>
</args>
```
??
I mean that is a deliberate input, no?
##########
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##########
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+ /**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
Between "raw" and "arguments" should be one space
> Deprecate InvocationRequest#setGoals
> ------------------------------------
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)