[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842960#comment-17842960
]
ASF GitHub Bot commented on MPLUGIN-521:
----------------------------------------
kwin commented on code in PR #281:
URL:
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587258849
##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##########
@@ -625,7 +625,7 @@ protected void writeParameterType(
}
}
- static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator,
String type) {
+ private static String extractbinaryNameForJavadoc(String type) {
Review Comment:
```suggestion
private static String extractBinaryNameForJavadoc(String type) {
```
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> ---------------------------------------------------------------------------------
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
> Affects Versions: 3.12.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.12.1
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map<String, List<Foo>>}} the generator will extract
> {{List<Foo>}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
