[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842869#comment-17842869
]
ASF GitHub Bot commented on MRESOLVER-554:
------------------------------------------
cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
- private final int maxThreads;
+ private final int maxDownstreamThreads;
+
+ private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
- private Executor executor;
+ private final ConcurrentHashMap<Boolean, Executor> executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch of switch), etc... with `boolean` there is no need for
null-check and can really be this or that. IF we have need to keep more than 2
executors for any reason, this can be easily extended to enum, but right now I
see no point of doing it.
> Support configuration of upload/download threads individually
> -------------------------------------------------------------
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Matt Nelson
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
