cstamas commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1587210763
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
- private final int maxThreads;
+ private final int maxDownstreamThreads;
+
+ private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
- private Executor executor;
+ private final ConcurrentHashMap<Boolean, Executor> executors;
Review Comment:
I disagree here, here is why: if I add enum, it will complicate method a
lot, will need to null-check it, will need to throw IAEx if not expected
(default branch), etc... with `boolean` there is no need for null-check and can
really be this or that. IF we have need to keep more than 2 executors for any
reason, this can be easily extended to enum, but right now I see no point of
doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
