[
https://issues.apache.org/jira/browse/MPMD-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841932#comment-17841932
]
Thomas Nikolay edited comment on MPMD-383 at 4/29/24 10:12 AM:
---------------------------------------------------------------
Andreas Dangel The parameter was not explicitly set - so it should use the
default value = true. That is, it works as designed. But from my point of view
this is a bad design decision.
Use case:
* Setting up a new project
* Setup PMD with errors
* New developer without experience develops some code - no errors appear
* Developer doesn't know he made some bugs
* after a while, someone with experience discovers that PMD does not work and
activates it. Then the code needs to be refactored.
My proposal would to set the default value to false
was (Author: tnikolay):
Andreas Dangel The parameter was not explicitly set - so it should use the
default value = true. That is, it works as designed. But from my point of view
this is a bad design decision.
Use case:
* Setting up a new project
* Setup PMD with errors
* New developer without experience develops some code - no errors appear
* Developer doesn't know he made some bugs
* after a while, someone with experience discovers that PMD does not work and
activates it. Then the code needs to be refactored.
> PMD should fail when there is a processing error
> ------------------------------------------------
>
> Key: MPMD-383
> URL: https://issues.apache.org/jira/browse/MPMD-383
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
> Affects Versions: 3.21.0
> Reporter: Thomas Nikolay
> Priority: Critical
> Fix For: waiting-for-feedback
>
> Attachments: image-2023-07-28-13-34-28-717.png
>
>
> We had the case that PMD can't process some processing error but the build
> does not fail.
>
> {noformat}
> [2023-07-28T10:59:44.102Z] [INFO] --- maven-pmd-plugin:3.20.0:pmd (pmd) @
> mod-config-client-cst ---
> [2023-07-28T10:59:44.692Z] [INFO] PMD version: 6.53.0
> [2023-07-28T10:59:45.672Z] [WARNING] Removed misconfigured rule:
> GK-SAP-ApacheLoggerDeniedRule cause: missing value
> [2023-07-28T10:59:45.672Z] [WARNING] There are 3 PMD processing errors:
> [2023-07-28T10:59:45.672Z] [WARNING]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java
> [2023-07-28T10:59:45.948Z] [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [2023-07-28T10:59:46.210Z] [INFO]
> [2023-07-28T10:59:46.210Z] [INFO] <<< maven-pmd-plugin:3.20.0:check
> (pmd-check) < :pmd @ mod-config-client-cst <<<
> {noformat}
>
> My expectation would be that the build failed when there a processing errors.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
