[
https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834723#comment-17834723
]
ASF GitHub Bot commented on SCM-914:
------------------------------------
michael-o commented on code in PR #193:
URL: https://github.com/apache/maven-scm/pull/193#discussion_r1555052807
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/info/JGitInfoCommand.java:
##########
@@ -74,6 +76,8 @@ protected ScmResult executeCommand(
return new InfoScmResult(infoItems, new
ScmResult("JGit.resolve(HEAD)", "", objectId.toString(), true));
} catch (Exception e) {
throw new ScmException("JGit resolve failure!", e);
+ } finally {
+ JGitUtils.closeRepo(git);
Review Comment:
Insane, this is unlogical.
> InfoItem.lastChangedDate is leaky abstraction
> ---------------------------------------------
>
> Key: SCM-914
> URL: https://issues.apache.org/jira/browse/SCM-914
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api
> Reporter: Tobias Gruetzmacher
> Assignee: Konrad Windszus
> Priority: Minor
>
> I was looking into implementing
> [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way,
> but had to conclude that InfoItem.lastChangedDate is unfortunately just a
> string and not a Data, so will leak the console output of different providers
> to the user.
> Does anybody see a sane way to fix this API and create a sane abstraction for
> different SCMs? If yes, I would try to go ahead with the following tasks:
> # Fix InfoItem, so that lastChangedDate is a Date
> # Fix the current providers filling this field (svnexe and svnjava AFAICS -
> aside: why is svnjava not part of the maven-scm repository?)
> # Implement this feature for at least gitexe (and maybe jgit) so I can use
> it for my usecase
> Ideas, comments?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
