[
https://issues.apache.org/jira/browse/MJLINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834239#comment-17834239
]
ASF GitHub Bot commented on MJLINK-83:
--------------------------------------
pedro-w opened a new pull request, #202:
URL: https://github.com/apache/maven-jlink-plugin/pull/202
This is a simple change to allow the Maven plugin to generate more than one
launcher in a `jlink` image. The `jlink` tool itself already supports this, but
there was no way to pass the required invocation onto it from Maven.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Allow adding multiple launchers to a jlink'ed image
> ---------------------------------------------------
>
> Key: MJLINK-83
> URL: https://issues.apache.org/jira/browse/MJLINK-83
> Project: Maven JLink Plugin
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Environment: (applies to all platforms)
> Reporter: Peter Hull
> Priority: Minor
>
> The {{jlink}} command line tool allows the {{--launcher}} argument to be
> specified multiple times to create multiple launcher scripts in the image.
> However the maven plugin only passes on one {{<launcher>}} element from its
> configuration section to the tool. If multiple are specified, the last one
> takes precedence. I would like to improve this so the plugin will pass
> multiple launcher specs on to the {{jlink}} tool. I suggest the config should
> look like:
> {noformat}
> <launcher>command=module/main</launcher>{noformat}
> (as before, for backward compatibility and the common case where there is
> only one)
> or
>
> {noformat}
> <launchers>
> <launcher>command1=module1/main1</launcher>
> <launcher>command2=module2/main2</launcher>
> ...
> </launchers>
> {noformat}
>
> where {{<launchers>}} can contain zero or more {{<launcher>}} elements with
> the same syntax as the existing element.
> One remaining question - what do do if the config specifies both
> {{<launcher>}} and {{<launchers>}} - combine the two or signal an error?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
