[
https://issues.apache.org/jira/browse/DOXIA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832875#comment-17832875
]
ASF GitHub Bot commented on DOXIA-723:
--------------------------------------
michael-o commented on code in PR #206:
URL: https://github.com/apache/maven-doxia/pull/206#discussion_r1546466352
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java:
##########
@@ -83,9 +85,16 @@ public Object invoke(Object proxy, Method method, Object[]
args) throws Throwabl
bufferedInvocations.clear();
} else if (method.equals(GET_BUFFERED_SINK_METHOD)) {
return delegate;
+ } else if (method.equals(GET_DOCUMENT_LOCATOR_METHOD)) {
+ return delegate.getDocumentLocator();
} else {
bufferedInvocations.add(new MethodWithArguments(method, args));
}
+ if (method.getReturnType() != Void.TYPE) {
+ throw new IllegalStateException(
+ "BufferingSinkProxy only works for methods returning
void, but given method " + method
+ + " requires another return type");
+ }
Review Comment:
Would it make sense to write out the actual method?
> Optionally expose document location in Sink
> -------------------------------------------
>
> Key: DOXIA-723
> URL: https://issues.apache.org/jira/browse/DOXIA-723
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Sink API
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 2.0.0, 2.0.0-M10
>
>
> Similar to http://www.saxproject.org/apidoc/org/xml/sax/Locator.html the Sink
> API should provide means to figure out the document location. This should be
> available whenever the Sink events are emitted from parsing a file.
> The locator should expose file name, line number and column number.
> This can be used to enhance warning/errors as otherwise it is very hard to
> figure out the root cause of messages like
> https://github.com/apache/maven-doxia/blob/e01880801ca1283b86205e2f7064b9b4dbc84d54/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L930.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
