desruisseaux commented on PR #1459: URL: https://github.com/apache/maven/pull/1459#issuecomment-2023960340
I suggest to provide only the `fatjar` type, without the `classpath-fatjar` and `modular-fatjar` for now, and modify the Javadoc of `fatjar` for saying that it goes on the classpath only. The reason is that a JAR file can contain at most one `module-info.class` file. So either the `module-info` or all JARs had to be removed, or either they were merged in some way. But the latter would be tricky, and the result would still not be the same as the separated JARs. So I think it is probably safer to said that a fat JAR is never modular. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
