ppalaga commented on code in PR #925: URL: https://github.com/apache/maven-mvnd/pull/925#discussion_r1526253989
########## README.adoc: ########## @@ -70,7 +69,7 @@ $ brew install mvndaemon/homebrew-mvnd/mvnd We're looking for contribution to support https://www.macports.org[MacPorts], https://community.chocolatey.org/packages/mvndaemon/[Chocolatey], https://scoop.sh/[Scoop] or -https://github.com/joschi/asdf-mvnd#install[asdf]. If you're fancy helping us... +https://github.com/joschi/asdf-mvnd#install[asdf]. If you fancy helping us... Review Comment: -1 on this change. The original was correct IMO. ########## README.adoc: ########## @@ -24,8 +24,7 @@ This architecture brings the following advantages: * The JVM for running the actual builds does not need to get started anew for each build. * The classloaders holding classes of Maven plugins are cached over multiple builds. The plugin jars are thus read and parsed just once. SNAPSHOT versions of Maven plugins are not cached. -* The native code produced by the Just-In-Time (JIT) compiler inside the JVM is kept too. Compared to stock Maven, - less time is spent by the JIT compilation. During the repeated builds the JIT-optimized code is available +* The native code produced by the Just-In-Time (JIT) compiler inside the JVM is kept too. JIT compilation is faster than stock Maven. During the repeated builds the JIT-optimized code is available Review Comment: > JIT compilation is faster than stock Maven. This changes the meaning in a wrong way. The changed sentence does not state anything useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
