[ 
https://issues.apache.org/jira/browse/MPLUGIN-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825868#comment-17825868
 ] 

ASF GitHub Bot commented on MPLUGIN-511:
----------------------------------------

hboutemy commented on code in PR #269:
URL: 
https://github.com/apache/maven-plugin-tools/pull/269#discussion_r1522315605


##########
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##########
@@ -150,6 +179,29 @@ protected void executeReport(Locale locale) throws 
MavenReportException {
         // Generate the mojos' documentation
         generateMojosDocumentation(pluginDescriptor, locale);
 
+        if (requirementsHistories.isEmpty()) {
+            // detect requirements history
+            String v = null;
+            try {
+                List<Version> versions = 
discoverVersions(detectRequirementsHistory);
+                getLog().info("Detecting requirements history for " + 
detectRequirementsHistory + ": "
+                        + versions.size());
+
+                Collections.reverse(versions);
+                for (Version version : versions) {
+                    v = version.toString();
+                    MavenProject versionProject = buildMavenProject(v);
+                    RequirementsHistory requirements = 
RequirementsHistory.discoverRequirements(versionProject);
+                    requirementsHistories.add(requirements);
+                    getLog().info("- " + requirements);

Review Comment:
   if you prefer: added 2 spaces





> create and share tooling to detect plugin prerequisites history
> ---------------------------------------------------------------
>
>                 Key: MPLUGIN-511
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-511
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: Plugin Plugin
>    Affects Versions: 3.11.0
>            Reporter: Herve Boutemy
>            Priority: Major
>             Fix For: 3.12.0
>
>
> to help creating documentation needed on plugins when implementing 
> MPLUGIN-400, i.e. fill requirementsHistories 
> [https://maven.apache.org/plugin-tools-archives/plugin-tools-3.7.0/maven-plugin-report-plugin/report-mojo.html#requirementshistories]
>  
> this will be useful both for Maven project itself, because we have 52 plugins 
> to work on 
> [https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-prerequisites.html]
> but this will help also every plugin maintainers: MojoHaus, others



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to