[
https://issues.apache.org/jira/browse/DOXIA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825761#comment-17825761
]
ASF GitHub Bot commented on DOXIA-732:
--------------------------------------
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-doxia/pull/203#discussion_r1521963586
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/UniqueAnchorNamesValidator.java:
##########
@@ -46,8 +50,7 @@ public void anchor(String name, SinkEventAttributes
attributes) {
private void enforceUniqueAnchor(String name) {
Review Comment:
This method name is incorrect now because it does not enforce anything
anymore. I think the if clause can be inlined and the method removed.
> Do not fail for duplicate anchor names
> --------------------------------------
>
> Key: DOXIA-732
> URL: https://issues.apache.org/jira/browse/DOXIA-732
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0.0-M9
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The {{UniqueAnchorNamesValidator}} added with DOXIA-722 fails with an ISE in
> case duplicate anchor names are found on a page
> (https://github.com/apache/maven-doxia/blob/7a04c033456511e1bd4870f03ba768d03158f368/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/UniqueAnchorNamesValidator.java#L49).
> As this only has a functional impact for links using the anchors the default
> behaviour should rather be a WARNING in the log.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
