michael-o commented on code in PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#discussion_r1521252180


##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-17/pom.xml:
##########
@@ -26,17 +26,15 @@
     <version>2.0.0-SNAPSHOT</version>
   </parent>
 
-  <artifactId>maven-resolver-transport-jdk-11</artifactId>
+  <artifactId>maven-resolver-transport-jdk-17</artifactId>
   <packaging>jar</packaging>
 
-  <name>Maven Artifact Resolver Transport JDK 11</name>
-  <description>Maven Artifact Transport JDK Java 11+.</description>
+  <name>Maven Artifact Resolver Transport JDK 17</name>
+  <description>Maven Artifact Transport JDK Java 17+.</description>

Review Comment:
   Why? Can't it then just be "Maven Artifact Resolver Transport JDK" or so?



##########
src/site/markdown/configuration.md:
##########
@@ -116,8 +116,8 @@ under the License.
 | 89. | `"aether.transport.http.supportWebDav"` | `java.lang.Boolean` | 
Boolean flag should the HTTP transport support WebDAV remote. Not all transport 
support this option. |  `false`  | 2.0.0 (moved out from 
maven-resolver-transport-http). |  Yes  | Session Configuration |
 | 90. | `"aether.transport.http.userAgent"` | `java.lang.String` | The user 
agent that repository connectors should report to servers. |  `"Aether"`  |  |  
No  | Session Configuration |
 | 91. | `"aether.transport.https.securityMode"` | `java.lang.String` | The 
mode that sets HTTPS transport "security mode": to ignore any SSL errors 
(certificate validity checks, hostname verification). The default value is . |  
`"default"`  | 1.9.6 |  Yes  | Session Configuration |
-| 92. | `"aether.transport.jdk.httpVersion"` | `java.lang.String` | Use string 
representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default 
HTTP protocol to use. |  `"HTTP_2"`  | 2.0.0 |  Yes  | Session Configuration |
-| 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `java.lang.Integer` | 
The hard limit of maximum concurrent requests JDK transport can do. This is a 
workaround for the fact, that in HTTP/2 mode, JDK HttpClient initializes this 
value to Integer.MAX_VALUE (!) and lowers it on first response from the remote 
server (but it may be too late). See JDK bug <a 
href="https://bugs.openjdk.org/browse/JDK-8225647";>JDK-8225647</a> for details. 
|  `100`  | 2.0.0 |  Yes  | Session Configuration |
+| 92. | `"aether.transport.jdk.httpVersion"` | `String` | Use string 
representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default 
HTTP protocol to use. |  `"HTTP_2"`  | 2.0.0 |  Yes  | Session Configuration |
+| 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `Integer` | The hard 
limit of maximum concurrent requests JDK transport can do. This is a workaround 
for the fact, that in HTTP/2 mode, JDK HttpClient initializes this value to 
Integer.MAX_VALUE (!) and lowers it on first response from the remote server 
(but it may be too late). See JDK bug <a 
href="https://bugs.openjdk.org/browse/JDK-8225647";>JDK-8225647</a> for details. 
|  `100`  | 2.0.0 |  Yes  | Session Configuration |

Review Comment:
   This does not make sense if the other references are still fully qualified 
and I would leave it fully qualified for consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to