[
https://issues.apache.org/jira/browse/MSITE-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825026#comment-17825026
]
Konrad Windszus edited comment on MSITE-1002 at 3/10/24 10:27 AM:
------------------------------------------------------------------
Attached are the HTML pages generated with v3 ( [^test-v3.html] ) and v4 (
[^test-v4.html] ).
The difference for the code section looks like this:
{code}
<main id="bodyColumn" class="span10" >
<div class="source"><pre class="prettyprint"><code class="language-java">int a
= 1;
</code></pre></div>
</main>
{code}
(v3 = working) vs
{code}
<main id="bodyColumn" class="span10">
<div class="verbatim">
<pre><code class="language-java">int a = 1;
</code></pre></div>
</main>
{code}
(v4 = non-working)
The JS library for code highlighting is
https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/js/prettify.js.
[~michael-o] Do you know where this is maintained and documented. This is hard
to see from the minified JS included in Fluido....
Update: Seems this is like a discontinued library from Google:
https://meta.stackexchange.com/questions/353983/goodbye-prettify-hello-highlight-js-swapping-out-our-syntax-highlighter.
We should probably change that as well.
was (Author: kwin):
Attached are the HTML pages generated with v3 ( [^test-v3.html] ) and v4 (
[^test-v4.html] ).
The difference for the code section looks like this:
{code}
<main id="bodyColumn" class="span10" >
<div class="source"><pre class="prettyprint"><code class="language-java">int a
= 1;
</code></pre></div>
</main>
{code}
(v3 = working) vs
{code}
<main id="bodyColumn" class="span10">
<div class="verbatim">
<pre><code class="language-java">int a = 1;
</code></pre></div>
</main>
{code}
(v4 = non-working)
The JS library for code highlighting is
https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/js/prettify.js.
[~michael-o] Do you know where this is maintained and documented. This is hard
to see from the minified JS included in Fluido....
> Maven Site 4 will break code highlight of site generated by Markdown
> --------------------------------------------------------------------
>
> Key: MSITE-1002
> URL: https://issues.apache.org/jira/browse/MSITE-1002
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration
> Affects Versions: 4.0.0-M13
> Reporter: Xavi Lee
> Assignee: Konrad Windszus
> Priority: Major
> Attachments: maven-site-3.png, maven-site-4.png, test-v3.html,
> test-v4.html
>
>
> repro repo https://github.com/awxiaoxian2020/code-render-bug
> master branch is Maven Site 3 with Fluido skin 1
> v4 branch is Maven Site 4 with Fluido skin 2.
> Open their respective `target/site/test.html` files in local to see the
> rendered result.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)