[ 
http://jira.codehaus.org/browse/SUREFIRE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102980
 ] 

Paul Gier commented on SUREFIRE-61:
-----------------------------------

The issue can be seen mainly when the fork mode is set to never.  Because if 
the surefire plugin forks, then the ordering gets rearranged similar to what 
Barrett described.  However, I think this is caused by loading the paths into 
the properties object and then using an enumeration to iterate through them.  
The Properties object doesn't retain the order of the loaded props, so they 
really could come out in any order, not just the sorted order that is shown 
above.

So I think that Barrett's approach is the right one.  The classpath elements 
really need to be sorted after they are loaded from properties file.  Hopefully 
someone will apply his patch or something similar to it soon :)

> Incorrect classpath ordering
> ----------------------------
>
>                 Key: SUREFIRE-61
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-61
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 3.x support
>    Affects Versions: 2.0 (2.2 plugin)
>         Environment: maven2.0.4, sun-jdk-1.5.0.09, maven-surefire-plugin 2.2, 
> surefire 2.0, gentoo linux x86
>            Reporter: Martin Vysny
>            Priority: Critical
>             Fix For: 2.4
>
>         Attachments: my-app.zip, output.log, 
> SUREFIRE61_barrettas_surefire_surefire-booter_for_rev_489098.patch
>
>
> Surefire incorrectly interprets classpath ordering.
> Steps to reproduce: 
> 1. unzip my-app.zip - it's a simple mvn project created with
> mvn archetype:create -DgroupId=com.mycompany.app -DartifactId=my-app
> and lightly patched 
> 2. mvn test
> in my case, it prints out
> jar:file:/home/vyzivus/.m2/repository/jxta/jxta/2.0/jxta-2.0.jar!/log4j.properties
> jar:file:/home/vyzivus/.m2/repository/jxta/jxta/2.0/jxta-2.0.jar!/log4j.properties
> which is incorrect. log4j.properties is located both in jxta.jar and 
> src/test/resources, but I think that src/test/resources takes precedence over 
> jxta. This ordering is set correctly in surefire36745tmp file I think, but 
> surefire seems to ignore the ordering.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to