[
https://issues.apache.org/jira/browse/MRESOLVER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821459#comment-17821459
]
ASF GitHub Bot commented on MRESOLVER-499:
------------------------------------------
gnodet commented on code in PR #435:
URL: https://github.com/apache/maven-resolver/pull/435#discussion_r1505156559
##########
maven-resolver-named-locks-ipc/src/main/java/org/eclipse/aether/named/ipc/IpcMessages.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.named.ipc;
+
+/**
+ * Constants used for the inter-process communication protocol.
+ *
+ * @since 2.0.0
+ */
+public class IpcMessages {
+
+ public static final String REQUEST_CONTEXT = "request-context";
+ public static final String REQUEST_ACQUIRE = "request-acquire";
+ public static final String REQUEST_CLOSE = "request-close";
+ public static final String REQUEST_STOP = "request-stop";
+ public static final String RESPONSE_CONTEXT = "response-context";
+ public static final String RESPONSE_ACQUIRE = "response-acquire";
+ public static final String RESPONSE_CLOSE = "response-close";
+ public static final String RESPONSE_STOP = "response-stop";
+}
Review Comment:
It would require rewriting the socket protocol, which is currently written
to read/write a `List<String>`, so definitely not an enum:
https://github.com/apache/maven-resolver/blob/814b6732a49447281ef085de3ef8542c45508371/maven-resolver-named-locks-ipc/src/main/java/org/eclipse/aether/named/ipc/IpcClient.java#L266-L308
> IPC Named Locks
> ---------------
>
> Key: MRESOLVER-499
> URL: https://issues.apache.org/jira/browse/MRESOLVER-499
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-9
>
>
> Create IPC named locks implementation. Depends on MRESOLVER-421.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
