[ 
https://issues.apache.org/jira/browse/SUREFIRE-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated SUREFIRE-2235:
------------------------------------------
    Description: 
We have such situation
{noformat}
if junit-platform-engine present on plugin dependencies - nothing is changed

else

   if junit-jupiter-api present on test dependencies then add 
junit-jupiter-engine

   if {{junit}} present on test dependencies then add junit-vintage-engine

{noformat}
{{junit-vintage-engine}} should be alweys added to runtime dependencies if 
JUnit 4 is present

In other case when we start moving or create one test with {{JUnit5}} in 
module, all old tests in {{JUnit4}} are silently skipped when we forgot to 
explicit add {{junit-vintage-engine}}  

artifact {{junit-jupiter}} has a transitive dependencies to 
junit-jupiter-engine and junit-platform-engine 
but {{junit-jupiter-api}} has no transitive dependencies

so when we use only {{junit-jupiter-api}} - {{junit-vintage-engine}}  is added.

  was:
We have such situation
{noformat}
if junit-platform-engine present on plugin dependencies - nothing is changed

else

   if junit-jupiter-api present on test dependencies then add 
junit-jupiter-engine

   if {{junit}} present on test dependencies then add junit-vintage-engine

{noformat}
{{junit-vintage-engine}} should be alweys added to runtime dependencies

In other case when we start moving or create one test with {{JUnit5}} in 
module, all old tests in {{JUnit4}} are silently skipped when we forgot to 
explicit add {{junit-vintage-engine}}  

artifact {{junit-jupiter}} has a transitive dependencies to 
junit-jupiter-engine and junit-platform-engine 
but {{junit-jupiter-api}} has no transitive dependencies

so when we use only {{junit-jupiter-api}} - {{junit-vintage-engine}}  is added.




> Manage of junit-vintage-engine is inconsistent
> ----------------------------------------------
>
>                 Key: SUREFIRE-2235
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2235
>             Project: Maven Surefire
>          Issue Type: Bug
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>
> We have such situation
> {noformat}
> if junit-platform-engine present on plugin dependencies - nothing is changed
> else
>    if junit-jupiter-api present on test dependencies then add 
> junit-jupiter-engine
>    if {{junit}} present on test dependencies then add junit-vintage-engine
> {noformat}
> {{junit-vintage-engine}} should be alweys added to runtime dependencies if 
> JUnit 4 is present
> In other case when we start moving or create one test with {{JUnit5}} in 
> module, all old tests in {{JUnit4}} are silently skipped when we forgot to 
> explicit add {{junit-vintage-engine}}  
> artifact {{junit-jupiter}} has a transitive dependencies to 
> junit-jupiter-engine and junit-platform-engine 
> but {{junit-jupiter-api}} has no transitive dependencies
> so when we use only {{junit-jupiter-api}} - {{junit-vintage-engine}}  is 
> added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to