kwin commented on code in PR #1412:
URL: https://github.com/apache/maven/pull/1412#discussion_r1488374066
##########
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java:
##########
@@ -576,6 +578,36 @@ public void validateEffectiveModel(Model ma,
ModelBuildingRequest request, Model
}
}
+ @Override
+ public void validateExternalProfiles(
+ List<org.apache.maven.model.Profile> activeExternalProfiles,
+ Model ma,
+ ModelBuildingRequest request,
+ ModelProblemCollector problems) {
+ org.apache.maven.api.model.Model m = ma.getDelegate();
+ // check for id clashes in repositories
+ for (Profile profile : activeExternalProfiles.stream()
+ .map(org.apache.maven.model.Profile::getDelegate)
+ .collect(Collectors.toList())) {
+ for (Repository repository : profile.getRepositories()) {
Review Comment:
TODO: Also check for clashing plugin repositories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
