gnodet commented on code in PR #425: URL: https://github.com/apache/maven-resolver/pull/425#discussion_r1480937529
########## maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/manager/DependencyManagerTest.java: ########## @@ -40,6 +41,8 @@ */ public class DependencyManagerTest { + private final SystemScopePredicate systemScopePredicate = "system"::equals; Review Comment: Would it make sense to have this constant shared for the whole codebase (and deprecated) instead of having this predicate defined dozens of time in various places ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org