[ 
https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810364#comment-17810364
 ] 

ASF GitHub Bot commented on MNG-8026:
-------------------------------------

cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464864632


##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##########
@@ -49,7 +49,9 @@
  * assist those clients that employ the repository system outside of an IoC 
container, Maven plugins should instead
  * always use regular dependency injection to acquire the repository system.
  *
+ * @deprecated See {@link MavenSessionBuilderSupplier}
  */
+@Deprecated
 public final class MavenRepositorySystemUtils {

Review Comment:
   These are all static methods, IMHO nope. 
   
   This class would be used only by some third party integration, but given 
current Maven4 is still alpha, I am more for dropping this class and use 
MavenSessionBuilderSupplier instead, in those apps that integrate Maven4. For 
those apps, the "price" for moving from Resolver1/Maven3 to Resolver2/Maven4 
would be this change. Or they should just use MIMA :smile: 





> Maven should define from ground up scopes used with Resolver
> ------------------------------------------------------------
>
>                 Key: MNG-8026
>                 URL: https://issues.apache.org/jira/browse/MNG-8026
>             Project: Maven
>          Issue Type: Task
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> See MRESOLVER-471, it is actually role of Maven (as a resolver consumer 
> project) to define all these things:
>  * supported scopes
>  * transformations of scopes to build path scopes
>  * fine tune conflict resolution and related things (in session)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to